-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add MATLAB support #147
Add MATLAB support #147
Conversation
And lots of changes to Matlab codegen and supporting files.
Mid-way through adapting the Vector/Array serializers to handle nested arrays/vectors. Next up are the Subarrays tests.
All passing. Next: - Clean up the Vector/Array serializers - Add C++ translator to RoundTripTest - Finish fixing computed fields and ComputedFieldsTest - Documentation
Instead of the entire stream into memory.
Also clean up Matlab code and improve serializer input validation.
@johnstairs When you are ready, you can follow the additions to On my Windows PC, where I run my devcontainer in WSL, my WSL shell profile export MATLAB_LICENSE_FILE=/mnt/c/Users/username/Downloads/Network.lic.com Be sure to restart all instances of VS Code before building the devcontainer. |
Should we have have the sandbox model generate MATLAB too? In the past, I've found that model to be a useful testbed for isolating problems |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you delete a top-level type (like a record or a protocol), we should make sure we delete the associated generated files.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
MyType: !record
fields:
a: int->string
If I create two instances and call a.eq(b)
, I get
Error using ==
Concatenating 'dictionary' objects is not supported because 'dictionary' objects can only be scalar.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
MyType: !record
fields:
a: int*
If I create two instances of this type where the a
fields have different lengths, eq
raises an error:
Arrays have incompatible sizes for this operation.
Error in == (line 20)
all([self.a] == [other.a]);
I don't know if we can customize a class' string representation, but say the default for union is not that helpful:
|
Co-authored-by: Joe Naegele <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great, Joe!
Adds Matlab support for the yardl binary format.
Closes #78.